Add validation functions accepting string length #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rmw_validate_full_topic_name_with_size() Add rmw_validate_namespace_with_size() Add rmw_validate_node_name_with_size()
wjwwood
approved these changes
Mar 15, 2018
Member
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
lgtm
I would have also been ok just changing the existing functions to always require the user to call strlen, but I wasn't clear about that and this is great too.
dabonnie
pushed a commit
to aws-ros-dev/rmw
that referenced
this pull request
Apr 2, 2019
Add rmw_validate_full_topic_name_with_size() Add rmw_validate_namespace_with_size() Add rmw_validate_node_name_with_size() Signed-off-by: Devin Bonnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the validation functions to allow passing the length of the string as a parameter. Adding these methods allows ros2/rcl#217 to avoid copying some strings while parsing remap rules.
rmw_validate_full_topic_name_with_size()rmw_validate_namespace_with_size()rmw_validate_node_name_with_size()CI